netdev - Re: patch for PCH_GBE rotten packet (Intel EG20T Platform Controller).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Jul 2016 09:59:08 -0700
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	Tom Walsh <tomwalsh73@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>
Subject: Re: patch for PCH_GBE rotten packet (Intel EG20T Platform Controller).

On Tue, Jul 26, 2016 at 9:00 AM, Tom Walsh <tomwalsh73@...il.com> wrote:
> Not sure how this goes, but, we found a race condition in
> drivers/net/ethernet/oki-semi/pch_gbe/
>
> The attached patch corrects for this.
>
> TomW

So a few minor changes are probably needed.

First we don't recommend the use of camel case for variable names.  So
"resetStatus" should probably be renamed to "reset_status".  Second is
the fact that you seemed to have removed a tab that didn't need to be
removed before the read of the INT_EN register.  Third you need to add
a "Signed-off-by" containing your name and email address.  Finally we
usually require the patches to be emailed inline to avoid having the
attachments stripped.

You might also wan to go through the steps called out in
https://www.kernel.org/doc/Documentation/SubmittingPatches

Hope this helps.

- Alex