netdev - Re: [PATCH net] l2tp: Correctly return -EBADF from pppol2tp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160726.151957.1214443852703588578.davem@davemloft.net>
Date:	Tue, 26 Jul 2016 15:19:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	phil.turnbull@...cle.com
Cc:	netdev@...r.kernel.org, jchapman@...alix.com
Subject: Re: [PATCH net] l2tp: Correctly return -EBADF from
 pppol2tp_getname.

From: Phil Turnbull <phil.turnbull@...cle.com>
Date: Tue, 26 Jul 2016 15:14:35 -0400

> If 'tunnel' is NULL we should return -EBADF but the 'end_put_sess' path
> unconditionally sets 'error' back to zero. Rework the error path so it
> more closely matches pppol2tp_sendmsg.
> 
> Fixes: fd558d186df2 ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts")
> Signed-off-by: Phil Turnbull <phil.turnbull@...cle.com>

Applied.