lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e5229894-45fc-671e-641a-e41c7ab176d7@st.com> Date: Tue, 26 Jul 2016 14:13:45 +0200 From: Giuseppe CAVALLARO <peppe.cavallaro@...com> To: Michael Weiser <michael.weiser@....de>, <linux-arm-kernel@...ts.infradead.org> CC: Alexandre Torgue <alexandre.torgue@...com>, <netdev@...r.kernel.org> Subject: Re: [PATCH 2/3] stmmac: change dma descriptors to __le32 On 7/21/2016 8:23 PM, Michael Weiser wrote: > The stmmac driver does not take into account the processor may be big > endian when writing the DMA descriptors. This causes the ethernet > interface not to be initialised correctly when running a big-endian > kernel. Change the descriptors for DMA to use __le32 and ensure they are > suitably swapped before writing. Tested successfully on the > Cubieboard2. Thx for the effort on big endian platform. > > Signed-off-by: Michael Weiser <michael.weiser@....de> > Cc: Giuseppe Cavallaro <peppe.cavallaro@...com> > Cc: Alexandre Torgue <alexandre.torgue@...com> > Cc: netdev@...r.kernel.org > --- ... > > @@ -2880,14 +2876,17 @@ static void sysfs_display_ring(void *head, int size, int extend_desc, > x = *(u64 *) ep; > seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n", > i, (unsigned int)virt_to_phys(ep), > - ep->basic.des0, ep->basic.des1, > - ep->basic.des2, ep->basic.des3); > - ep++; > + le32_to_cpu(ep->basic.des0), > + le32_to_cpu(ep->basic.des1), > + le32_to_cpu(ep->basic.des2), > + le32_to_cpu(ep->basic.des3)); > + ep++); there is a build problem here. Pls fix it. Peppe
Powered by blists - more mailing lists