lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160727221001.GA3338@electric-eye.fr.zoreil.com> Date: Thu, 28 Jul 2016 00:10:01 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Chunhao Lin <hau@...ltek.com> Cc: netdev@...r.kernel.org, nic_swsd@...ltek.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting. Chunhao Lin <hau@...ltek.com> : [...] > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index 0e62d74..f07604f 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c [...] > @@ -1852,12 +1863,17 @@ static int rtl8169_set_wol(struct net_device *dev, struct ethtool_wolinfo *wol) > tp->features |= RTL_FEATURE_WOL; > else > tp->features &= ~RTL_FEATURE_WOL; > - __rtl8169_set_wol(tp, wol->wolopts); > + if (pm_runtime_active(&pdev->dev)) > + __rtl8169_set_wol(tp, wol->wolopts); > + else > + tp->saved_wolopts = wol->wolopts; > > rtl_unlock_work(tp); > > device_set_wakeup_enable(&tp->pci_dev->dev, wol->wolopts); > > + pm_runtime_put_noidle(&pdev->dev); > + > return 0; Either the driver resumes the device so that it can perform requested operation or it signals .set_wol failure when the device is suspended. If the driver does something else, "spam removal" translates to "silent failure". -- Ueimor
Powered by blists - more mailing lists