lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <cc2ab963-3d26-78d7-2119-bc00bcbbd1c7@ti.com> Date: Wed, 27 Jul 2016 11:15:25 +0530 From: Mugunthan V N <mugunthanvnm@...com> To: Peter Chen <peter.chen@....com>, <davem@...emloft.net> CC: <netdev@...r.kernel.org>, <vbridger@...nsource.altera.com>, <isubramanian@....com>, <kchudgar@....com>, <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, <thomas.petazzoni@...e-electrons.com>, <sergei.shtylyov@...entembedded.com>, <peppe.cavallaro@...com>, <alexandre.torgue@...com>, <tremyfr@...il.com>, <wxt@...k-chips.com>, <arnd@...db.de>, <david.daney@...ium.com>, <huangdaode@...ilicon.com>, <jszhang@...vell.com> Subject: Re: [PATCH 15/15] ethernet: ti: davinci_emac: add missing of_node_put after calling of_parse_phandle On Wednesday 27 July 2016 07:50 AM, Peter Chen wrote: > of_node_put needs to be called when the device node which is got > from of_parse_phandle has finished using. > > Signed-off-by: Peter Chen <peter.chen@....com> > --- > drivers/net/ethernet/ti/davinci_emac.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/ti/davinci_emac.c b/drivers/net/ethernet/ti/davinci_emac.c > index c6c5465..d8cb9d0 100644 > --- a/drivers/net/ethernet/ti/davinci_emac.c > +++ b/drivers/net/ethernet/ti/davinci_emac.c > @@ -1571,6 +1571,7 @@ static int emac_dev_open(struct net_device *ndev) > if (priv->phy_node) { > phydev = of_phy_connect(ndev, priv->phy_node, > &emac_adjust_link, 0, 0); > + of_node_put(priv->phy_node); > if (!phydev) { > dev_err(emac_dev, "could not connect to phy %s\n", > priv->phy_node->full_name); > phy_node is accessed in case of of_phy_connect() returns error, so it has to be moved after the dev_err log Regards Mugunthan V N
Powered by blists - more mailing lists