netdev - Re: [PATCH net] be2net: perform temperature query in adapter regardless of its interface state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160726.232030.1883209020880684696.davem@davemloft.net>
Date:	Tue, 26 Jul 2016 23:20:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	gpiccoli@...ux.vnet.ibm.com
Cc:	sathya.perla@...adcom.com, ajit.khaparde@...adcom.com,
	padmanabh.ratnakar@...adcom.com,
	sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] be2net: perform temperature query in adapter
 regardless of its interface state

From: "Guilherme G. Piccoli" <gpiccoli@...ux.vnet.ibm.com>
Date: Tue, 26 Jul 2016 17:39:42 -0300

> The be2net driver performs fw temperature queries on be_worker() routine,
> which is executed each second for each be_adapter. There is a frequency
> threshold to avoid fw query to happens at each call to be_worker();
> instead, currently a fw query occurs once in 64 runs of the procedure.
> 
> Nevertheless, this fw temperature query is invoked only for adapters which
> interface is up, so we can see I/O errors on read of hwmon counters from
> userspace (from tools like lm-sensors) in case we have adapters' functions
> which interface is down.
> 
> This patch moves the fw query code to be invoked even if interface is down.
> No functional changes were introduced.
> 
> Signed-off-by: Guilherme G. Piccoli <gpiccoli@...ux.vnet.ibm.com>

Applied.