lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1469586048-15697-4-git-send-email-peter.chen@nxp.com> Date: Wed, 27 Jul 2016 10:20:36 +0800 From: Peter Chen <peter.chen@....com> To: <davem@...emloft.net> CC: <netdev@...r.kernel.org>, <vbridger@...nsource.altera.com>, <isubramanian@....com>, <kchudgar@....com>, <yisen.zhuang@...wei.com>, <salil.mehta@...wei.com>, <thomas.petazzoni@...e-electrons.com>, <sergei.shtylyov@...entembedded.com>, <peppe.cavallaro@...com>, <alexandre.torgue@...com>, <mugunthanvnm@...com>, <tremyfr@...il.com>, <wxt@...k-chips.com>, <arnd@...db.de>, <david.daney@...ium.com>, <huangdaode@...ilicon.com>, <jszhang@...vell.com>, Peter Chen <peter.chen@....com> Subject: [PATCH 03/15] ethernet: arc: emac_main: add missing of_node_put after calling of_parse_phandle of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen <peter.chen@....com> --- drivers/net/ethernet/arc/emac_main.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/arc/emac_main.c b/drivers/net/ethernet/arc/emac_main.c index 586beda..0e6331c 100644 --- a/drivers/net/ethernet/arc/emac_main.c +++ b/drivers/net/ethernet/arc/emac_main.c @@ -749,14 +749,16 @@ int arc_emac_probe(struct net_device *ndev, int interface) err = of_address_to_resource(dev->of_node, 0, &res_regs); if (err) { dev_err(dev, "failed to retrieve registers base from device tree\n"); - return -ENODEV; + err = -ENODEV; + goto out_put_node; } /* Get IRQ from device tree */ irq = irq_of_parse_and_map(dev->of_node, 0); if (!irq) { dev_err(dev, "failed to retrieve <irq> value from device tree\n"); - return -ENODEV; + err = -ENODEV; + goto out_put_node; } ndev->netdev_ops = &arc_emac_netdev_ops; @@ -778,7 +780,7 @@ int arc_emac_probe(struct net_device *ndev, int interface) err = clk_prepare_enable(priv->clk); if (err) { dev_err(dev, "failed to enable clock\n"); - return err; + goto out_put_node; } clock_frequency = clk_get_rate(priv->clk); @@ -787,7 +789,8 @@ int arc_emac_probe(struct net_device *ndev, int interface) if (of_property_read_u32(dev->of_node, "clock-frequency", &clock_frequency)) { dev_err(dev, "failed to retrieve <clock-frequency> from device tree\n"); - return -EINVAL; + err = -EINVAL; + goto out_put_node; } } @@ -877,6 +880,9 @@ out_mdio: out_clken: if (priv->clk) clk_disable_unprepare(priv->clk); +out_put_node: + of_node_put(phy_node); + return err; } EXPORT_SYMBOL_GPL(arc_emac_probe); -- 1.9.1
Powered by blists - more mailing lists