netdev - Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160728045747.GH5710@gauss.secunet.com>
Date:	Thu, 28 Jul 2016 06:57:47 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Vegard Nossum <vegard.nossum@...cle.com>
CC:	Stephen Hemminger <stephen@...workplumber.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH] xfrm: use printk instead of WARN for bad policy reporting

On Wed, Jul 27, 2016 at 08:03:18AM +0200, Vegard Nossum wrote:
> Subject: [PATCH] xfrm: get rid of incorrect WARN
> 
> AFAICT this message is just printed whenever input validation fails.
> This is a normal failure and we shouldn't be dumping the stack over it.
> 
> Looks like it was originally a printk that was maybe incorrectly
> upgraded to a WARN:
> 
> commit 62db5cfd70b1ef53aa21f144a806fe3b78c84fab
> Author: stephen hemminger <shemminger@...tta.com>
> Date:   Wed May 12 06:37:06 2010 +0000
> 
>     xfrm: add severity to printk
> 
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Cc: Steffen Klassert <steffen.klassert@...unet.com>
> Signed-off-by: Vegard Nossum <vegard.nossum@...cle.com>

Applied to the ipsec tree, thanks!