netdev - RE: [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <HE1PR04MB1450F5FFDD38BB2B99ED24A68B000@HE1PR04MB1450.eurprd04.prod.outlook.com>
Date:	Thu, 28 Jul 2016 03:43:08 +0000
From:	Peter Chen <peter.chen@....com>
To:	Yisen Zhuang <Yisen.zhuang@...wei.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"vbridger@...nsource.altera.com" <vbridger@...nsource.altera.com>,
	"isubramanian@....com" <isubramanian@....com>,
	"kchudgar@....com" <kchudgar@....com>,
	"salil.mehta@...wei.com" <salil.mehta@...wei.com>,
	"thomas.petazzoni@...e-electrons.com" 
	<thomas.petazzoni@...e-electrons.com>,
	"sergei.shtylyov@...entembedded.com" 
	<sergei.shtylyov@...entembedded.com>,
	"peppe.cavallaro@...com" <peppe.cavallaro@...com>,
	"alexandre.torgue@...com" <alexandre.torgue@...com>,
	"mugunthanvnm@...com" <mugunthanvnm@...com>,
	"tremyfr@...il.com" <tremyfr@...il.com>,
	"wxt@...k-chips.com" <wxt@...k-chips.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"david.daney@...ium.com" <david.daney@...ium.com>,
	"huangdaode@...ilicon.com" <huangdaode@...ilicon.com>,
	"jszhang@...vell.com" <jszhang@...vell.com>
Subject: RE: [PATCH 06/15] ethernet: hisilicon: hns: hns_dsaf_mac: add missing
 of_node_put after calling of_parse_phandle

 
>在 2016/7/27 10:20, Peter Chen 写道:
>> of_node_put needs to be called when the device node which is got from
>> of_parse_phandle has finished using.
>>
>> Signed-off-by: Peter Chen <peter.chen@....com>
>> ---
>>  drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
>> b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
>> index 3fb87e2..18d72ea 100644
>> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
>> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
>> @@ -786,6 +786,7 @@ static int  hns_mac_get_info(struct hns_mac_cb *mac_cb)
>>  		np = of_parse_phandle(mac_cb->dev->of_node, "phy-handle",
>>  				      mac_cb->mac_id);
>>  		mac_cb->phy_dev = of_phy_find_device(np);
>> +		of_node_put(np);
>>  		if (mac_cb->phy_dev) {
>>  			/* refcount is held by of_phy_find_device()
>>  			 * if the phy_dev is found
>
>np is accessed in case of of_phy_find_device() returns a no null value, so it has to be
>moved after the dev_dbg log.
>
>> @@ -804,6 +805,7 @@ static int  hns_mac_get_info(struct hns_mac_cb *mac_cb)
>>  		np = of_parse_phandle(to_of_node(mac_cb->fw_port),
>>  				      "phy-handle", 0);
>>  		mac_cb->phy_dev = of_phy_find_device(np);
>> +		of_node_put(np);
>>  		if (mac_cb->phy_dev) {
>>  			/* refcount is held by of_phy_find_device()
>>  			 * if the phy_dev is found
>
>np is accessed in case of of_phy_find_device() returns a no null value, so it has to be
>moved after the dev_dbg log.
>

Thanks, I will change them.

Peter