netdev - RE: [PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put after calling of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Jul 2016 01:57:04 +0000
From:	Peter Chen <peter.chen@....com>
To:	David Daney <ddaney@...iumnetworks.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"vbridger@...nsource.altera.com" <vbridger@...nsource.altera.com>,
	"isubramanian@....com" <isubramanian@....com>,
	"kchudgar@....com" <kchudgar@....com>,
	"yisen.zhuang@...wei.com" <yisen.zhuang@...wei.com>,
	"salil.mehta@...wei.com" <salil.mehta@...wei.com>,
	"thomas.petazzoni@...e-electrons.com" 
	<thomas.petazzoni@...e-electrons.com>,
	"sergei.shtylyov@...entembedded.com" 
	<sergei.shtylyov@...entembedded.com>,
	"peppe.cavallaro@...com" <peppe.cavallaro@...com>,
	"alexandre.torgue@...com" <alexandre.torgue@...com>,
	"mugunthanvnm@...com" <mugunthanvnm@...com>,
	"tremyfr@...il.com" <tremyfr@...il.com>,
	"wxt@...k-chips.com" <wxt@...k-chips.com>,
	"arnd@...db.de" <arnd@...db.de>,
	"david.daney@...ium.com" <david.daney@...ium.com>,
	"huangdaode@...ilicon.com" <huangdaode@...ilicon.com>,
	"jszhang@...vell.com" <jszhang@...vell.com>
Subject: RE: [PATCH 05/15] ethernet: cavium: octeon: add missing of_node_put
 after calling of_parse_phandle

 
>
>> ---
>>   drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
>> b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
>> index e8bc15b..5eb9d8c 100644
>> --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
>> +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c
>> @@ -960,6 +960,7 @@ static int octeon_mgmt_init_phy(struct net_device *netdev)
>>   	phydev = of_phy_connect(netdev, p->phy_np,
>>   				octeon_mgmt_adjust_link, 0,
>>   				PHY_INTERFACE_MODE_MII);
>> +	of_node_put(p->phy_np);
>
>I don't think you can do this here.  octeon_mgmt_init_phy() may be called multiple
>times in the life of the driver, so p->phy_np must remain valid.
>
>It may be appropriate to do the  of_node_put() in the
>octeon_mgmt_remove() function.
 
Thanks, I will change it.

Peter