netdev - RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80377ECBC5453840BA8C7155328B53770143B749@RTITMBSV03.realtek.com.tw>
Date:	Thu, 28 Jul 2016 12:58:44 +0000
From:	Hau <hau@...ltek.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	nic_swsd <nic_swsd@...ltek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net 1/3] r8169:fix kernel log spam when set or get hardware wol setting.

[...]
> > @@ -1852,12 +1863,17 @@ static int rtl8169_set_wol(struct net_device
> *dev, struct ethtool_wolinfo *wol)
> >  		tp->features |= RTL_FEATURE_WOL;
> >  	else
> >  		tp->features &= ~RTL_FEATURE_WOL;
> > -	__rtl8169_set_wol(tp, wol->wolopts);
> > +	if (pm_runtime_active(&pdev->dev))
> > +		__rtl8169_set_wol(tp, wol->wolopts);
> > +	else
> > +		tp->saved_wolopts = wol->wolopts;
> >
> >  	rtl_unlock_work(tp);
> >
> >  	device_set_wakeup_enable(&tp->pci_dev->dev, wol->wolopts);
> >
> > +	pm_runtime_put_noidle(&pdev->dev);
> > +
> >  	return 0;
> 
> Either the driver resumes the device so that it can perform requested
> operation or it signals .set_wol failure when the device is suspended.
> 
> If the driver does something else, "spam removal" translates to "silent
> failure".

Because "tp->saved_wolopts" will be used to set hardware wol capability in rtl8169_runtime_resume().  So I prefer to keep "wol->wolopts" to " tp->saved_wolopts " in runtime suspend state and set this to this "wol->wolopts" to hardware in in rtl8169_runtime_resume(). 

Thanks.

------Please consider the environment before printing this e-mail.