netdev - Re: [PATCH ipsec] xfrm: Ignore socket policies when rebuilding hash tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160729104017.GA5710@gauss.secunet.com>
Date:	Fri, 29 Jul 2016 12:40:17 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
CC:	Tobias Brunner <tobias@...ongswan.org>,
	"David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	Christophe Gouault <christophe.gouault@...nd.com>
Subject: Re: [PATCH ipsec] xfrm: Ignore socket policies when rebuilding hash
 tables

On Fri, Jul 29, 2016 at 04:19:11PM +0800, Herbert Xu wrote:
> On Fri, Jul 29, 2016 at 09:57:32AM +0200, Tobias Brunner wrote:
> > Whenever thresholds are changed the hash tables are rebuilt.  This is
> > done by enumerating all policies and hashing and inserting them into
> > the right table according to the thresholds and direction.
> > 
> > Because socket policies are also contained in net->xfrm.policy_all but
> > no hash tables are defined for their direction (dir + XFRM_POLICY_MAX)
> > this causes a NULL or invalid pointer dereference after returning from
> > policy_hash_bysel() if the rebuild is done while any socket policies
> > are installed.
> > 
> > Since the rebuild after changing thresholds is scheduled this crash
> > could even occur if the userland sets thresholds seemingly before
> > installing any socket policies.
> > 
> > Fixes: 53c2e285f970 ("xfrm: Do not hash socket policies")
> > Signed-off-by: Tobias Brunner <tobias@...ongswan.org>
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied to the ipsec tree, thanks a lot Tobias!