netdev - Re: [PATCH v5 4/8] thunderbolt: Communication with the ICM (firmware)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160729140326.1fae0ced@xeon-e3>
Date:	Fri, 29 Jul 2016 14:03:26 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Amir Levy <amir.jer.levy@...el.com>
Cc:	andreas.noever@...il.com, gregkh@...uxfoundation.org,
	bhelgaas@...gle.com, corbet@....net, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, thunderbolt-linux@...el.com,
	mika.westerberg@...el.com, tomas.winkler@...el.com
Subject: Re: [PATCH v5 4/8] thunderbolt: Communication with the ICM
 (firmware)

On Thu, 28 Jul 2016 11:15:17 +0300
Amir Levy <amir.jer.levy@...el.com> wrote:

> +int nhi_send_message(struct tbt_nhi_ctxt *nhi_ctxt, enum pdf_value pdf,
> +		     u32 msg_len, const u8 *msg, bool ignore_icm_resp)
> +{

Why not make msg a void * and not have to do so many casts?