lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Jul 2016 09:14:40 -0500 From: Larry Finger <Larry.Finger@...inger.net> To: Heinrich Schuchardt <xypron.glpk@....de>, Chaoming Li <chaoming_li@...lsil.com.cn>, Kalle Valo <kvalo@...eaurora.org> Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] rtlwifi: remove superfluous condition On 07/31/2016 05:30 AM, Heinrich Schuchardt wrote: > If sta == NULL, the changed line will not be reached. > So no need to check if stat == NULL here. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de> > --- > drivers/net/wireless/realtek/rtlwifi/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I agree. If sta were NULL, we would never have reached this statement. There is, however, a typo in the last line of the commit message. Once this is fixed, you may add the line "Acked-by: Larry Finger <Larry.Finger@...inger.net>" Thanks, Larry > > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwifi/core.c > index 41f77f8..7aee5ebb1 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/core.c > +++ b/drivers/net/wireless/realtek/rtlwifi/core.c > @@ -1135,7 +1135,7 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw, > mac->mode = WIRELESS_MODE_AC_24G; > } > > - if (vif->type == NL80211_IFTYPE_STATION && sta) > + if (vif->type == NL80211_IFTYPE_STATION) > rtlpriv->cfg->ops->update_rate_tbl(hw, sta, 0); > rcu_read_unlock(); > >
Powered by blists - more mailing lists