netdev - Re: [PATCH -next] tipc: fix imbalance read_unlock_bh in __tipc_nl_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160730.203843.632827280409597213.davem@davemloft.net>
Date:	Sat, 30 Jul 2016 20:38:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	weiyj.lk@...il.com
Cc:	jon.maloy@...csson.com, ying.xue@...driver.com,
	parthasarathy.bhuvaragan@...csson.com, netdev@...r.kernel.org,
	tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH -next] tipc: fix imbalance read_unlock_bh in
 __tipc_nl_add_monitor()

From: Wei Yongjun <weiyj.lk@...il.com>
Date: Thu, 28 Jul 2016 02:07:49 +0000

> In the error handling case of nla_nest_start() failed read_unlock_bh()
> is called  to unlock a lock that had not been taken yet. sparse warns
> about the context imbalance as the following:
> 
> net/tipc/monitor.c:799:23: warning:
>  context imbalance in '__tipc_nl_add_monitor' - different lock contexts for basic block
> 
> Fixes: cf6f7e1d5109 ('tipc: dump monitor attributes')
> Signed-off-by: Wei Yongjun <weiyj.lk@...il.com>

Applied.