netdev - Re: [PATCH net-next 2/3] bna: change type of bna_id to atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <345d713a-8399-b1ff-718a-ccf4547ecd4f@redhat.com>
Date:	Mon, 1 Aug 2016 17:11:00 +0200
From:	Ivan Vecera <ivecera@...hat.com>
To:	David Laight <David.Laight@...LAB.COM>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:	"rasesh.mody@...gic.com" <rasesh.mody@...gic.com>
Subject: Re: [PATCH net-next 2/3] bna: change type of bna_id to atomic_t

On 1.8.2016 16:20, David Laight wrote:
> From: Ivan Vecera
>> Sent: 29 July 2016 18:53
>> Change type of bna_id to atomic_t. The bnad_list_mutex is used to prevent
>> a race when bna_id is incremented. After the change the mutex can be
>> removed in the next step.
> ...
>> -static u32 bna_id;
>> +static atomic_t bna_id;
> ...
>>  	bnad_lock_init(bnad);
>>  	bnad_add_to_list(bnad);
>> +	bnad->id = atomic_inc_return(&bna_id) - 1;
> ...
>
> Is the 'id' expected to be unique?
> Looks like they get reallocated after 2^32 allocates.
>
> 	David
>
>
I have just converted it to atomic type to eliminate mutex. The id is 
only used as parameter 'instance' for bfa_nw_flash_{update,read}_part(). 
There is no documentation in source code regarding this so this is a 
question to Qlogic.

Ivan