netdev - [PATCH 0805/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160802114812.3632-1-baolex.ni@intel.com>
Date:	Tue,  2 Aug 2016 19:48:12 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	wei.liu2@...rix.com, kvalo@...eaurora.org, linuxwifi@...el.com,
	m.chehab@...sung.com, pawel@...iak.com, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com
Cc:	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, chuansheng.liu@...el.com,
	baolex.ni@...el.com
Subject: [PATCH 0805/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 drivers/net/xen-netback/netback.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index edbae0b..e6e6598 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -53,22 +53,22 @@
  * enabled by default.
  */
 bool separate_tx_rx_irq = true;
-module_param(separate_tx_rx_irq, bool, 0644);
+module_param(separate_tx_rx_irq, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 /* The time that packets can stay on the guest Rx internal queue
  * before they are dropped.
  */
 unsigned int rx_drain_timeout_msecs = 10000;
-module_param(rx_drain_timeout_msecs, uint, 0444);
+module_param(rx_drain_timeout_msecs, uint, S_IRUSR | S_IRGRP | S_IROTH);
 
 /* The length of time before the frontend is considered unresponsive
  * because it isn't providing Rx slots.
  */
 unsigned int rx_stall_timeout_msecs = 60000;
-module_param(rx_stall_timeout_msecs, uint, 0444);
+module_param(rx_stall_timeout_msecs, uint, S_IRUSR | S_IRGRP | S_IROTH);
 
 unsigned int xenvif_max_queues;
-module_param_named(max_queues, xenvif_max_queues, uint, 0644);
+module_param_named(max_queues, xenvif_max_queues, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(max_queues,
 		 "Maximum number of queues per virtual interface");
 
@@ -78,7 +78,7 @@ MODULE_PARM_DESC(max_queues,
  */
 #define FATAL_SKB_SLOTS_DEFAULT 20
 static unsigned int fatal_skb_slots = FATAL_SKB_SLOTS_DEFAULT;
-module_param(fatal_skb_slots, uint, 0444);
+module_param(fatal_skb_slots, uint, S_IRUSR | S_IRGRP | S_IROTH);
 
 /* The amount to copy out of the first guest Tx slot into the skb's
  * linear area.  If the first slot has more data, it will be mapped
@@ -92,7 +92,7 @@ module_param(fatal_skb_slots, uint, 0444);
 /* This is the maximum number of flows in the hash cache. */
 #define XENVIF_HASH_CACHE_SIZE_DEFAULT 64
 unsigned int xenvif_hash_cache_size = XENVIF_HASH_CACHE_SIZE_DEFAULT;
-module_param_named(hash_cache_size, xenvif_hash_cache_size, uint, 0644);
+module_param_named(hash_cache_size, xenvif_hash_cache_size, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(hash_cache_size, "Number of flows in the hash cache");
 
 static void xenvif_idx_release(struct xenvif_queue *queue, u16 pending_idx,
-- 
2.9.2