lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160802113951.30127-1-baolex.ni@intel.com> Date: Tue, 2 Aug 2016 19:39:51 +0800 From: Baole Ni <baolex.ni@...el.com> To: jeffrey.t.kirsher@...el.com, benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au, computersforpeace@...il.com, m.chehab@...sung.com, pawel@...iak.com, m.szyprowski@...sung.com, kyungmin.park@...sung.com, k.kozlowski@...sung.com Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, chuansheng.liu@...el.com, baolex.ni@...el.com, fw@...len.de, davem@...emloft.net, Baohua.Song@....com Subject: [PATCH 0721/1285] Replace numeric parameter like 0444 with macro I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com> Signed-off-by: Baole Ni <baolex.ni@...el.com> --- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c b/drivers/net/ethernet/intel/ixgb/ixgb_main.c index 31f9145..ccc30c6 100644 --- a/drivers/net/ethernet/intel/ixgb/ixgb_main.c +++ b/drivers/net/ethernet/intel/ixgb/ixgb_main.c @@ -41,7 +41,7 @@ static const char ixgb_copyright[] = "Copyright (c) 1999-2008 Intel Corporation. #define IXGB_CB_LENGTH 256 static unsigned int copybreak __read_mostly = IXGB_CB_LENGTH; -module_param(copybreak, uint, 0644); +module_param(copybreak, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(copybreak, "Maximum size of packet that is copied to a new buffer on receive"); -- 2.9.2
Powered by blists - more mailing lists