netdev - Re: [PATCH net] openvswitch: Remove incorrect WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPWQB7FyNnDh8+jc1n6Djs8UFLC4=xL=xU8J94rdqF8TzcuCkg@mail.gmail.com>
Date:	Tue, 2 Aug 2016 14:12:01 -0700
From:	Joe Stringer <joe@....org>
To:	Jarno Rajahalme <jarno@....org>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] openvswitch: Remove incorrect WARN_ONCE().

On 1 August 2016 at 19:36, Jarno Rajahalme <jarno@....org> wrote:
> ovs_ct_find_existing() issues a warning if an existing conntrack entry
> classified as IP_CT_NEW is found, with the premise that this should
> not happen.  However, a newly confirmed, non-expected conntrack entry
> remains IP_CT_NEW as long as no reply direction traffic is seen.  This
> has resulted into somewhat confusing kernel log messages.  This patch
> removes this check and warning.
>
> Fixes: 289f2253 ("openvswitch: Find existing conntrack entry after upcall.")
> Suggested-by: Joe Stringer <joe@....org>
> Signed-off-by: Jarno Rajahalme <jarno@....org>

Thanks for the patch, this will remove a false positive kernel log
from a common case in OVS with stateful processing.

Acked-by: Joe Stringer <joe@....org>