netdev - Re: [PATCH 1083/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160802092720.5b150b85@gandalf.local.home>
Date:	Tue, 2 Aug 2016 09:27:20 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Baole Ni <baolex.ni@...el.com>
Cc:	davem@...emloft.net, jiangshanlai@...il.com,
	mathieu.desnoyers@...icios.com, m.chehab@...sung.com,
	gregkh@...uxfoundation.org, m.szyprowski@...sung.com,
	kyungmin.park@...sung.com, k.kozlowski@...sung.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	chuansheng.liu@...el.com, oleg@...hat.com,
	gang.chen.5i5j@...il.com, mhocko@...e.com, koct9i@...il.com,
	aarcange@...hat.com, aryabinin@...tuozzo.com
Subject: Re: [PATCH 1083/1285] Replace numeric parameter like 0444 with
 macro

On Tue,  2 Aug 2016 20:14:55 +0800
Baole Ni <baolex.ni@...el.com> wrote:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 

NACK!

I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH.

-- Steve

> Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
> Signed-off-by: Baole Ni <baolex.ni@...el.com>
> ---
>  net/802/garp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/802/garp.c b/net/802/garp.c
> index b38ee6d..ecc976a 100644
> --- a/net/802/garp.c
> +++ b/net/802/garp.c
> @@ -22,7 +22,7 @@
>  #include <asm/unaligned.h>
>  
>  static unsigned int garp_join_time __read_mostly = 200;
> -module_param(garp_join_time, uint, 0644);
> +module_param(garp_join_time, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(garp_join_time, "Join time in ms (default 200ms)");
>  MODULE_LICENSE("GPL");
>