netdev - Re: [PATCH 0/2] HFSC patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160801.212711.1833470473467715535.davem@davemloft.net>
Date:	Mon, 01 Aug 2016 21:27:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	soltys@....info
Cc:	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH 0/2] HFSC patches

From: Michal Soltys <soltys@....info>
Date: Mon,  1 Aug 2016 01:03:57 +0200

> - first patch:
> 
> This patch syncs virtual times with fair service curve and fixes a very old
> subtle bug.
> 
> The detailed explanation is in the commit message. Additionally
> I've made an illustration to help understand the issue better:
> 
> http://imgur.com/a/N8uMC
> 
> See the example at the bottom of the commit message - Am1_3 and Am2_3 is what
> should happen with such queue setup, Am1_3real and Am2_3real is what actually
> happens due to rtsc_min() calculating minimum from corrected and uncorrected
> curves.
> 
> - second patch:
> 
> This is trivial patch that comments out one unused variable, related to another
> commented out piece of code.

Don't just comment it out, if it's unused delete it entirely.