netdev - [PATCH 1139/1285] Replace numeric parameter like 0444 with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160802121946.26050-1-baolex.ni@intel.com>
Date:	Tue,  2 Aug 2016 20:19:46 +0800
From:	Baole Ni <baolex.ni@...el.com>
To:	bfields@...ldses.org, jlayton@...chiereds.net,
	trond.myklebust@...marydata.com, anna.schumaker@...app.com,
	davem@...emloft.net, kadlec@...ckhole.kfki.hu,
	m.szyprowski@...sung.com, kyungmin.park@...sung.com,
	k.kozlowski@...sung.com
Cc:	linux-nfs@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, chuansheng.liu@...el.com,
	baolex.ni@...el.com, arnd@...db.de, aryabinin@...tuozzo.com
Subject: [PATCH 1139/1285] Replace numeric parameter like 0444 with macro

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@...el.com>
Signed-off-by: Baole Ni <baolex.ni@...el.com>
---
 net/sunrpc/xprtsock.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 7e2b2fa..51dec63 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -3166,8 +3166,8 @@ static const struct kernel_param_ops param_ops_portnr = {
 #define param_check_portnr(name, p) \
 	__param_check(name, p, unsigned int);
 
-module_param_named(min_resvport, xprt_min_resvport, portnr, 0644);
-module_param_named(max_resvport, xprt_max_resvport, portnr, 0644);
+module_param_named(min_resvport, xprt_min_resvport, portnr, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param_named(max_resvport, xprt_max_resvport, portnr, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
 static int param_set_slot_table_size(const char *val,
 				     const struct kernel_param *kp)
@@ -3202,9 +3202,9 @@ static const struct kernel_param_ops param_ops_max_slot_table_size = {
 	__param_check(name, p, unsigned int);
 
 module_param_named(tcp_slot_table_entries, xprt_tcp_slot_table_entries,
-		   slot_table_size, 0644);
+		   slot_table_size, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 module_param_named(tcp_max_slot_table_entries, xprt_max_tcp_slot_table_entries,
-		   max_slot_table_size, 0644);
+		   max_slot_table_size, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 module_param_named(udp_slot_table_entries, xprt_udp_slot_table_entries,
-		   slot_table_size, 0644);
+		   slot_table_size, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 
-- 
2.9.2