lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <57A26106.50206@codeaurora.org> Date: Wed, 3 Aug 2016 16:24:22 -0500 From: Timur Tabi <timur@...eaurora.org> To: Arnd Bergmann <arnd@...db.de> Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org, sdharia@...eaurora.org, shankerd@...eaurora.org, vikrams@...eaurora.org, cov@...eaurora.org, gavidov@...eaurora.org, robh+dt@...nel.org, andrew@...n.ch, bjorn.andersson@...aro.org, mlangsdo@...hat.com, jcm@...hat.com, agross@...eaurora.org, davem@...emloft.net, f.fainelli@...il.com, catalin.marinas@....com Subject: Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver Arnd Bergmann wrote: > As I said, this is inherently driver specific. If setting the 64-bit > mask fails, the driver itself needs to fall back to the 32-bit mask > so it can allocate buffers from ZONE_DMA instead of ZONE_NORMAL. I just posted a v7 of my patch, but I forgot to fix the dma_set_mask call. I'll post a v8 soon, but before I do, what do you think of this: /* The EMAC itself is capable of 64-bit DMA, so try that first. */ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (ret) { /* Some platforms may restrict the EMAC's address bus to less * then the size of DDR. In this case, we need to try a * smaller mask. We could try every possible smaller mask, * but that's overkill. Instead, just fall to 32-bit, which * should always work. */ ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) { dev_err(&pdev->dev, "could not set DMA mask\n"); return ret; } } -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists