netdev - Re: [PATCH] ipv4: panic in leaf_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgT0Ud_Rou5qeF5xkdRqytBxyAYBEsRzN1F7MjTf0-Bk0H3_A@mail.gmail.com>
Date:	Wed, 3 Aug 2016 16:02:36 -0700
From:	Alexander Duyck <alexander.duyck@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	dforster@...cade.com, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv4: panic in leaf_walk_rcu due to stale node pointer

On Wed, Aug 3, 2016 at 12:01 PM, David Miller <davem@...emloft.net> wrote:
> From: David Forster <dforster@...cade.com>
> Date: Wed, 3 Aug 2016 15:13:01 +0100
>
>> Panic occurs when issuing "cat /proc/net/route" whilst
>> populating FIB with > 1M routes.
>>
>> Use of cached node pointer in fib_route_get_idx is unsafe.
>  ...
>> Signed-off-by: Dave Forster <dforster@...cade.com>
>
> Alexander, please review.
>
> Thanks.

It took me a bit to recall how this worked.  This looks good to me.

By the way, I am glad you emailed my Gmail because my Mirantis email
is no more, I am back to working for Intel.

Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>