netdev - Re: [PATCH v2 2/3] sctp_diag: export timer value only if it is active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160803233652.4709D647E4@mail.nwl.cc>
Date:	Thu, 4 Aug 2016 01:39:32 +0200
From:	Phil Sutter <phil@....cc>
To:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Xin Long <lucien.xin@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v2 2/3] sctp_diag: export timer value only if it is active

On Wed, Aug 03, 2016 at 06:51:15PM -0300, Marcelo Ricardo Leitner wrote:
> On Wed, Aug 03, 2016 at 11:23:12PM +0200, Phil Sutter wrote:
> > Since it is exported as unsigned value, userspace has no way detecting
> > whether it is negative or just very large. Therefore do this in kernel
> > space where it is a simple comparison.
> > 
> > Signed-off-by: Phil Sutter <phil@....cc>
> > ---
> > Changes since v1:
> > - Introduce local variable to shorten long lines.
> > - Use timer_pending() to decide whether to export the timer value.
> > - Export the primary path's value instead of garbage.
> 
> This is now the most important change on the patch IMO. Can we mention
> it on changelog itself?
> 
> A Fixes tag is welcomed too, as previous values were incorrect.

Oh right, thanks for pointing this out. I will follow-up with a fixed
v3.

Thanks, Phil