netdev - Re: [Patch net-next] net_sched: remove the leftover cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d82351ba-cd1e-d5e1-0faa-94c2bcaf720a@mojatatu.com>
Date:	Wed, 3 Aug 2016 07:36:29 -0400
From:	Jamal Hadi Salim <jhs@...atatu.com>
To:	Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org
Subject: Re: [Patch net-next] net_sched: remove the leftover cleanup_a()

Cong,

Improvement on the basic test as it no longer oopses, but:
here's a test that will oops:
-----------------------------
# add action that will be shared for multi-flows
sudo tc actions add action drop index 10
#add an action noone uses
sudo tc actions add action ok index 12
#
sudo tc actions ls action gact
# see both dumped... (good)
#Lets bind the shared action twice
#
sudo tc qdisc del dev lo parent ffff:
sudo tc qdisc add dev lo ingress
#
#use existing action index 10
sudo tc filter add dev lo parent ffff: protocol ip prio 8 \
u32 match ip dst 127.0.0.8/32 flowid 1:10 action gact index 10
#use existing action index 10
sudo tc filter add dev lo parent ffff: protocol ip prio 7 \
u32 match ip src 127.0.0.10/32 flowid 1:11 action gact index 10
# and now dump and see an oops
sudo tc filter ls dev lo parent ffff: protocol ip
-------------------

And btw, this should be submitted to -net not -net-next and should
specify something along the lines of "broken-by .."

cheers,
jamal