lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160803.115232.837383021887790928.davem@davemloft.net> Date: Wed, 03 Aug 2016 11:52:32 -0700 (PDT) From: David Miller <davem@...emloft.net> To: arnd@...db.de Cc: isubramanian@....com, kchudgar@....com, tinamdar@....com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: xgene: fix maybe-uninitialized variable From: Arnd Bergmann <arnd@...db.de> Date: Tue, 2 Aug 2016 12:23:29 +0200 > Building with -Wmaybe-uninitialized shows a potential use of > an uninitialized variable: > > drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function 'xgene_enet_phy_connect': > drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:802:23: warning: 'phy_dev' may be used uninitialized in this function [-Wmaybe-uninitialized] > > Although the compiler correctly identified this based on the function, > the current code is still safe as long dev->of_node is non-NULL > for the case of CONFIG_ACPI=n, which is currently the case. > > The warning is now disabled by default, but still appears when > building with W=1, and other build test tools should be able to > detect it as well. Adding an #else clause here makes the code > more robust and makes it clear to the compiler that this cannot > happen. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > Fixes: 8089a96f601b ("drivers: net: xgene: Add backward compatibility") Applied.
Powered by blists - more mailing lists