netdev - Re: [PATCH 1/1] VSOCK: remove more space available check filling TX vq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69d05004-506c-dbc2-f97e-b71f4945c703@cogentembedded.com>
Date:	Fri, 5 Aug 2016 19:53:46 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	ggarcia@...a.uab.cat, netdev@...r.kernel.org
Cc:	stefanha@...hat.com, mst@...hat.com
Subject: Re: [PATCH 1/1] VSOCK: remove more space available check filling TX
 vq

On 08/05/2016 07:34 PM, ggarcia@...a.uab.cat wrote:

> From: Gerard Garcia <ggarcia@...c.uab.cat>
>
> Remove unnecessary use of enable/disable callback notifications
> and the incorrect more space available check.
>
> The virtio_transport_tx_work handles when the TX virtqueue
> has more buffers available.
>
> Signed-off-by: Gerard Garcia <ggarcia@...c.uab.cat>
> ---
>  net/vmw_vsock/virtio_transport.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index 699dfab..b7a1055 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
[...]
> @@ -118,13 +114,12 @@ virtio_transport_send_pkt_work(struct work_struct *work)
>  		}
>
>  		ret = virtqueue_add_sgs(vq, sgs, out_sg, in_sg, pkt, GFP_KERNEL);
> +		/* Usually this means that there is no more space available in
> +		 * the vq */

    The preferred comment style in the networking code is:

/* bla
  * bla
  */

[...]

MBR, Sergei