netdev - Re: [PATCH iproute v2 2/5] ila: Support for configuring ila to use netfilter hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160806103346.56f7c33a@xeon-e3>
Date:	Sat, 6 Aug 2016 10:33:46 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Tom Herbert <tom@...bertland.com>
Cc:	Stephen Hemminger <shemming@...cade.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-team@...com" <kernel-team@...com>
Subject: Re: [PATCH iproute v2 2/5] ila: Support for configuring ila to use
 netfilter hook

I have no problem with this series in general and wanted to put it in before
closing the lid on 4.7 version, BUT.

This patch generates warnings when built on Debian Strech with gcc-5
 
ipila.c: In function ‘ila_parse_opt.constprop’:
ipila.c:205:2: warning: ‘locator_match’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  addattr64(n, 1024, ILA_ATTR_LOCATOR_MATCH, locator_match);

	if (matches(*argv, "add") == 0)
> +		return do_add(argc-1, argv+1);
> +	if (matches(*argv, "delete") == 0)
> +		return do_del(argc-1, argv+1);
> +	if (matches(*argv, "list") == 0)
> +		return do_list(argc-1, argv+1);
> +	if (matches(*argv, "help") == 0)
> +		usage();
> +
> +	fprintf(stderr, "Command \"%s\" is unknown, try \"ip ila help\".\n",
> +		*argv);
> +	exit(-1);
> +}
> +

You also added a blank line at end of file.

Please fix this and resubmit the series.