lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160808212112.GI22974@cork> Date: Mon, 8 Aug 2016 14:21:12 -0700 From: Jörn Engel <joern@...estorage.com> To: dingtianhong <dingtianhong@...wei.com>, Jay Vosburgh <fubar@...ibm.com>, "David S. Miller" <davem@...emloft.net> Cc: Andy Gospodarek <andy@...yhouse.net>, netdev@...r.kernel.org Subject: Re: [Regression] Bonding no longer support tun-interfaces Redirected by Davem. Is there a mailing list or a maintainer for regressions? There used to be, but I've been out of the loop for a while. On Mon, Aug 08, 2016 at 02:15:30PM -0700, Jörn Engel wrote: > This has been reported (and ignored) before: > http://lkml.iu.edu/hypermail/linux/kernel/1407.2/03790.html > https://bugzilla.kernel.org/show_bug.cgi?id=89161 > > Regression was introduced by: > > commit 00503b6f702e (refs/bisect/bad) > Author: dingtianhong <dingtianhong@...wei.com> > Date: Sat Jan 25 13:00:29 2014 +0800 > > bonding: fail_over_mac should only affect AB mode at enslave and removal processing > > According to bonding.txt, the fail_over_ma should only affect active-backup mode, > but I found that the fail_over_mac could be set to active or follow in all > modes, this will cause new slave could not be set to bond's MAC address at > enslave processing and restore its own MAC address at removal processing. > > The correct way to fix the problem is that we should not add restrictions when > setting options, just need to modify the bond enslave and removal processing > to check the mode in addition to fail_over_mac when setting a slave's MAC during > enslavement. The change active slave processing already only calls the fail_over_mac > function when in active-backup mode. > > Thanks for Jay's suggestion. > > The patch also modify the pr_warning() to pr_warn(). > > Cc: Jay Vosburgh <fubar@...ibm.com> > Cc: Veaceslav Falico <vfalico@...hat.com> > Cc: Andy Gospodarek <andy@...yhouse.net> > Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> > Signed-off-by: David S. Miller <davem@...emloft.net> > > Since I never needed bonding or tun-interfaces before, I come late to > the party. Some 6k lines have changed in the bonding driver since the > regression got in two years ago. So a simple revert is unlikely to lead > to happiness. > > But I absolutely need that functionality and would rather run a 3.13 > kernel than live with the regression. dingtianhong, any suggestions? > > Jörn > > -- > It is a cliché that most clichés are true, but then, like most clichés, > that cliché is untrue. > -- Stephen Fry Jörn -- I can say that I spend most of my time fixing bugs even if I have lots of new features to implement in mind, but I give bugs more priority. -- Andrea Arcangeli, 2000
Powered by blists - more mailing lists