netdev - A potential race in drivers/atm/eni.ko

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <3f46f924-29e9-a8f9-c9e7-531cb6dc0765@ispras.ru>
Date:	Mon, 8 Aug 2016 11:17:00 +0300
From:	Pavel Andrianov <andrianov@...ras.ru>
To:	Chas Williams <3chas3@...il.com>
Cc:	linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Vaishali Thakkar <vaishali.thakkar@...cle.com>,
	ldv-project@...uxtesting.org
Subject: A potential race in drivers/atm/eni.ko

Hi!

There is a potential race in drivers/atm/eni.ko.

In the interrupt handler eni_int the field eni_dev->events is masked 
(line 1519) with a spinlock protection. In eni_start eni_dev->events is 
initialized (line 1844), but it is done after interrupts are requested 
(line 1813). Thus, the interrupt may occur while initialization is not 
finishing and the new value of events will be lost. Moreover, the 
spinlock, which is used in the interrupt handler, is also initialized 
(line 1842) after request_irq (line 1813).

-- 
Pavel Andrianov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: andrianov@...ras.ru