lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <8822c3be-56c1-d9ac-7f7d-164804322083@Netapp.com> Date: Mon, 8 Aug 2016 09:49:56 -0400 From: Anna Schumaker <Anna.Schumaker@...app.com> To: Amitoj Kaur Chawla <amitoj1606@...il.com>, <bfields@...ldses.org>, <jlayton@...chiereds.net>, <trond.myklebust@...marydata.com>, <davem@...emloft.net>, <linux-nfs@...r.kernel.org>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> CC: <julia.lawall@...6.fr> Subject: Re: [PATCH] sunrpc: Remove unnecessary variable On 08/08/2016 05:13 AM, Amitoj Kaur Chawla wrote: > The variable `err` is not used anywhere and just returns the > predefined value `0` at the end of the function. Hence, remove the > variable and return 0 explicitly. Makes sense to me. Thanks! Anna > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com> > --- > net/sunrpc/clnt.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > index b7f2104..0a775fa 100644 > --- a/net/sunrpc/clnt.c > +++ b/net/sunrpc/clnt.c > @@ -184,7 +184,6 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event, > struct super_block *sb) > { > struct dentry *dentry; > - int err = 0; > > switch (event) { > case RPC_PIPEFS_MOUNT: > @@ -201,7 +200,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event, > printk(KERN_ERR "%s: unknown event: %ld\n", __func__, event); > return -ENOTSUPP; > } > - return err; > + return 0; > } > > static int __rpc_pipefs_event(struct rpc_clnt *clnt, unsigned long event, >
Powered by blists - more mailing lists