lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160808172839.2cc42c61@griffin> Date: Mon, 8 Aug 2016 17:28:39 +0200 From: Jiri Benc <jbenc@...hat.com> To: Simon Horman <simon.horman@...ronome.com> Cc: pravin shelar <pshelar@....org>, Linux Kernel Network Developers <netdev@...r.kernel.org>, ovs dev <dev@...nvswitch.org> Subject: Re: [ovs-dev] [PATCH net-next v11 5/6] openvswitch: add layer 3 flow/port support On Mon, 8 Aug 2016 17:17:17 +0200, Simon Horman wrote: > +bool skb_mac_header_present(struct sk_buff *skb) > +{ > + return skb->dev->type == ARPHRD_ETHER || > + (skb->dev->type == ARPHRD_NONE && > + skb->protocol == htons(ETH_P_TEB)); > +} > +EXPORT_SYMBOL(skb_mac_header_present); I'd suggest a different name, this looks like it has something to do with skb->mac_header, which it doesn't. skb_eth_header_present, perhaps? Jiri
Powered by blists - more mailing lists