netdev - Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKD1Yr03OGoOGtCB9JTCkpQhiPGh+wZRMB96YNSy4WzR2ckTow@mail.gmail.com>
Date:	Tue, 9 Aug 2016 01:24:17 +0900
From:	Lorenzo Colitti <lorenzo@...gle.com>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	Erik Kline <ek@...gle.com>, David Miller <davem@...emloft.net>,
	吉藤英明 <hideaki.yoshifuji@...aclelinux.com>
Subject: Re: [PATCH net] net: ipv6: Fix ping to link-local addresses.

On Tue, Aug 9, 2016 at 12:27 AM, David Ahern <dsa@...ulusnetworks.com> wrote:
> > -     if (!fl6.flowi6_oif && ipv6_addr_is_multicast(&fl6.daddr))
> > -             fl6.flowi6_oif = np->mcast_oif;
> > -     else if (!fl6.flowi6_oif)
> > -             fl6.flowi6_oif = np->ucast_oif;
> > -
>
> That code removal is contrary to your patch description regarding flowi6_oif.

Which code removal? The one I quote above? That code wasn't removed,
it was moved to above the initialization of flowi6.