netdev - Re: [PATCH net 2/3] mlxsw: spectrum: Do not override PAUSE settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160808162934.GM1944@nanopsycho.orion>
Date:	Mon, 8 Aug 2016 18:29:34 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Ido Schimmel <idosch@...lanox.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, jiri@...lanox.com,
	eladr@...lanox.com, yotamg@...lanox.com, nogahf@...lanox.com,
	ogerlitz@...lanox.com
Subject: Re: [PATCH net 2/3] mlxsw: spectrum: Do not override PAUSE settings

Thu, Aug 04, 2016 at 04:36:21PM CEST, idosch@...lanox.com wrote:
>The PFCC register is used to configure both PAUSE and PFC frames.
>Therefore, when PFC frames are disabled we must make sure we don't
>mistakenly also disable PAUSE frames (which might be enabled).
>
>Fix this by packing the PFCC register with the current PAUSE settings.
>
>Note that this register is also accessed via ethtool ops, but there we
>are guaranteed to have PFC disabled.
>
>Fixes: d81a6bdb87ce ("mlxsw: spectrum: Add IEEE 802.1Qbb PFC support")
>Signed-off-by: Ido Schimmel <idosch@...lanox.com>
Reviewed-by: Jiri Pirko <jiri@...lanox.com>