netdev - Re: [Patch net 5/5] net_sched: convert tcf_exts from list to flex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUT1sqK_QiC-dbWGGCBNSjdQbqr117_Fx2oxnh14=rnTA@mail.gmail.com>
Date:	Tue, 9 Aug 2016 11:02:08 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Amir Vadai <amir@...ai.me>
Cc:	netdev <netdev@...r.kernel.org>,
	Jamal Hadi Salim <jhs@...atatu.com>
Subject: Re: [Patch net 5/5] net_sched: convert tcf_exts from list to flex_array

On Tue, Aug 9, 2016 at 1:03 AM, Amir Vadai <amirva@...il.com> wrote:
>
>> -#define tc_single_action(_exts) \
>> -       (list_is_singular(&(_exts)->actions))
>> +#define tc_no_actions(_exts)  (&(_exts)->nr_actions == 0)
>> +#define tc_single_action(_exts) (&(_exts)->nr_actions == 1)
>
> Should remove the '&' here.

Good catch! I even didn't notice the '&' there. :-/

I will wait for Jamal's comments before sending v2.

Thanks.