netdev - Re: [PATCH net v2] vti: flush x-netns xfrm cache when vti interface is removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160809.125831.2234397547026038583.davem@davemloft.net>
Date:	Tue, 09 Aug 2016 12:58:31 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	lrichard@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net v2] vti: flush x-netns xfrm cache when vti
 interface is removed

From: Lance Richardson <lrichard@...hat.com>
Date: Tue,  9 Aug 2016 15:29:42 -0400

> When executing the script included below, the netns delete operation
> hangs with the following message (repeated at 10 second intervals):
> 
>   kernel:unregister_netdevice: waiting for lo to become free. Usage count = 1
> 
> This occurs because a reference to the lo interface in the "secure" netns
> is still held by a dst entry in the xfrm bundle cache in the init netns.
> 
> Address this problem by garbage collecting the tunnel netns flow cache
> when a cross-namespace vti interface receives a NETDEV_DOWN notification.
 ...
> Reported-by: Hangbin Liu <haliu@...hat.com>
> Reported-by: Jan Tluka <jtluka@...hat.com>
> Signed-off-by: Lance Richardson <lrichard@...hat.com>
> ---
> v2: Perform garbage collection on NETDEV_DOWN notification (v1 did this 
>     in uninit op handler).

Looks good, applied and queued up for -stable, thanks!