lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160809.144047.675292713371843984.davem@davemloft.net> Date: Tue, 09 Aug 2016 14:40:47 -0700 (PDT) From: David Miller <davem@...emloft.net> To: ubraun@...ux.vnet.ibm.com Cc: netdev@...r.kernel.org, linux-s390@...r.kernel.org, schwidefsky@...ibm.com, heiko.carstens@...ibm.com, utz.bacher@...ibm.com Subject: Re: [PATCH RESEND net-next 15/15] smc: proc-fs interface for smc connections From: Ursula Braun <ubraun@...ux.vnet.ibm.com> Date: Tue, 9 Aug 2016 12:13:00 +0200 > + sock_hold(&smc->sk); ... > +out_line: > + seq_putc(m, '\n'); > + sock_put(&smc->sk); You hold the smc_proc_list_lock during this function's execution, therefore the table cannot change and therefore the socket cannot go away. Therefore taking a reference count here is unnecessary overhead, please remove it.
Powered by blists - more mailing lists