netdev - Re: [PATCH net-next v3 1/3] strparser: Stream parser for messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Aug 2016 16:14:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tom@...bertland.com
Cc:	netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH net-next v3 1/3] strparser: Stream parser for messages

From: Tom Herbert <tom@...bertland.com>
Date: Mon, 1 Aug 2016 14:28:47 -0700

> +/* Lower lock held */
> +void strp_parser_err(struct strparser *strp, int err, read_descriptor_t *desc)
> +{
> +	desc->error = err;
> +	kfree_skb(strp->rx_skb_head);
> +	strp->rx_skb_head = NULL;
> +	strp_abort_rx_strp(strp, err);
> +}

Unused outside of this file, please mark "static".

> +void strp_queue_work(struct strparser *strp)
> +{
> +	queue_work(strp_wq, &strp->rx_work);
> +}

Completely unused, please remove.

Thanks.