lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 9 Aug 2016 13:56:15 +0530 From: Mugunthan V N <mugunthanvnm@...com> To: Grygorii Strashko <grygorii.strashko@...com>, "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org> CC: Sekhar Nori <nsekhar@...com>, <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org> Subject: Re: [PATCH] net: ethernet: ti: cpdma: remove used_desc counter On Thursday 04 August 2016 08:50 PM, Grygorii Strashko wrote: > The struct cpdma_desc_pool->used_desc field can be safely removed from > CPDMA driver (and hot patch) because used_descs counter is used just > for pool consistency check at CPDMA deinitialization and now this > check can be re-implemnted using gen_pool_size(pool->gen_pool) != > gen_pool_avail(pool->gen_pool). > More over, this will allow to get rid of warnings in > cpdma_desc_pool_destro()-> WARN_ON(pool->used_desc) which may happen > because the used_descs is used unprotected, since CPDMA has been > switched to use genalloc, and may get wrong values on SMP. > > Hence, remove used_desc from struct cpdma_desc_pool. > > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com> Reviewed-by: Mugunthan V N <mugunthanvnm@...com> Regards Mugunthan V N
Powered by blists - more mailing lists