netdev - Re: qdisc hash table changes...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1608091101220.22028@cbobk.fhfr.pm>
Date:	Tue, 9 Aug 2016 11:02:43 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	David Miller <davem@...emloft.net>
cc:	netdev@...r.kernel.org
Subject: Re: qdisc hash table changes...

On Tue, 9 Aug 2016, David Miller wrote:

> > It does indirectly pull in some networking headers, but it doesn't pull in 
> > netdevice.h (which is the place where the actual include of hashtable.h 
> > happens):
> 
> It pulls in skbuff.h, so are you willing to bet forever that skbuff.h
> won't indirectly pull in netdevice.h at some point in the future?
> 
> This is obviously a big problem, having global namespace conflicts
> like this.
> 
> Pushing fixing it propering into the future isn't really the right
> thing to do.
> 
> So please entertain my request to do this properly.

Ok, I will add this to my TODO list, but this can take quite some time 
(especially as I can imagine some maintainers pushing back on this, 
because it doesn't really fix any existing issue in their code).

Does that strictly have to be a show-stopper for the qdisc hash 
conversion, given the fact that the whole tree is building properly?

> Thank you.

Thanks,

-- 
Jiri Kosina
SUSE Labs