netdev - [PATCH] smc: fix boolreturn.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Aug 2016 20:55:59 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Ursula Braun <ubraun@...ux.vnet.ibm.com>
Cc:	kbuild-all@...org, davem@...emloft.net, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, utz.bacher@...ibm.com,
	ubraun@...ux.vnet.ibm.com
Subject: [PATCH] smc: fix boolreturn.cocci warnings

net/smc/smc_wr.c:274:10-11: WARNING: return of 0/1 in function 'smc_wr_tx_has_pending' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

CC: Ursula Braun <ubraun@...ux.vnet.ibm.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 smc_wr.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/net/smc/smc_wr.c
+++ b/net/smc/smc_wr.c
@@ -271,9 +271,9 @@ bool smc_wr_tx_has_pending(struct smc_li
 			continue;
 		tx_pend = &link->wr_tx_pends[i].priv;
 		if (filter(tx_pend, data))
-			return 1;
+			return true;
 	}
-	return 0;
+	return false;
 }
 
 /****************************** receive queue ********************************/