netdev - Re: [PATCH] net: ipconfig: fix use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160810.145546.383556730317744645.davem@davemloft.net>
Date:	Wed, 10 Aug 2016 14:55:46 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	u.kleine-koenig@...gutronix.de, netdev@...r.kernel.org,
	linux-renesas-soc@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] net: ipconfig: fix use after free

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Wed, 10 Aug 2016 12:00:35 +0200

> Hi Uwe,
> 
> On Wed, Aug 10, 2016 at 11:44 AM, Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de> wrote:
>> ic_close_devs() calls kfree() for all devices's ic_device. Since commit
>> 2647cffb2bc6 ("net: ipconfig: Support using "delayed" DHCP replies")
>> the active device's ic_device is still used however to print the
>> ipconfig summary which results in an oops if the memory is already
>> changed. So delay freeing until after the autoconfig results are
>> reported.
> 
> Thanks!
> 
>> Fixes: 2647cffb2bc6 ("net: ipconfig: Support using "delayed" DHCP replies")
>> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>

Applied, thanks everyone.