netdev - Re: [PATCH 2/2] ravb: add sleep PM suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79a23b1c-9f73-e004-87d9-256bc408e633@cogentembedded.com>
Date:	Wed, 10 Aug 2016 13:47:26 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	David Miller <davem@...emloft.net>,
	niklas.soderlund+renesas@...natech.se
Cc:	netdev@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	wsa@...-dreams.de
Subject: Re: [PATCH 2/2] ravb: add sleep PM suspend/resume support

Hello.

On 8/10/2016 2:16 AM, David Miller wrote:

>> The interface would not function after the system had been woken up
>> after have been suspended (echo mem > /sys/power/state) cycle. The
>> reason for this is that all device registers have been reset to its
>> default values. This patch adds sleep suspend and resume functions that
>> detached the interface at suspend and restore the registers and reattach
>> the interface at resume.
>>
>> Only the registers that are only configured at probe time needs to be
>> explicitly restored by the resume handler. All other registers are
>> reconfigured by either reopening the device in the resume handler (if
>> the device was running when the system was suspended) or when the
>> interface is opened by a user at a later time.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
>
> Applied to net-next, thanks.

    Ugh, I should have reviewed the patch earlier -- I was postponing this 
until I have the time to test it... Since the patch did have some visible 
issues, it should've been recast before applying. DaveM, please in the future 
could you ping me before merging?

MBR, Sergei