netdev - Re: [PATCH] openvswitch: do not ignore netdev errors when creating tunnel vports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOrHB_D6Zi0TgTGRDr_mSidRox9O26YhPhkXGK3Yx4v7CjsDHw@mail.gmail.com>
Date:	Wed, 10 Aug 2016 10:26:16 -0700
From:	pravin shelar <pshelar@....org>
To:	Martynas Pumputis <martynas@...ve.works>
Cc:	Pravin Shelar <pshelar@...ira.com>,
	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	ovs dev <dev@...nvswitch.org>
Subject: Re: [PATCH] openvswitch: do not ignore netdev errors when creating
 tunnel vports

On Tue, Aug 9, 2016 at 8:24 AM, Martynas Pumputis <martynas@...ve.works> wrote:
> The creation of a tunnel vport (geneve, gre, vxlan) brings up a
> corresponding netdev, a multi-step operation which can fail.
>
> For example, changing a vxlan vport's netdev state to 'up' binds the
> vport's socket to a UDP port - if the binding fails (e.g. due to the
> port being in use), the error is currently ignored giving the
> appearance that the tunnel vport creation completed successfully.
>
> Signed-off-by: Martynas Pumputis <martynas@...ve.works>

Thanks.

Acked-by: Pravin B Shelar <pshelar@....org>