netdev - Re: [iproute PATCH] ip-route: Pretty-print expired routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9d2afc01-bb48-25f7-9cad-7c4926622a38@solarflare.com>
Date:	Thu, 11 Aug 2016 14:46:26 +0100
From:	Edward Cree <ecree@...arflare.com>
To:	Phil Sutter <phil@....cc>, Stephen Hemminger <shemming@...cade.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [iproute PATCH] ip-route: Pretty-print expired routes

On 10/08/16 12:14, Phil Sutter wrote:
> Instead of printing 'expires -23sec' for expired (but not yet garbage
> collected) routes, print 'expired 23sec' instead.
>
> Signed-off-by: Phil Sutter <phil@....cc>
> ---
>  ip/iproute.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/ip/iproute.c b/ip/iproute.c
> index c52294d298210..a89a26d68be0f 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -305,6 +305,14 @@ static void print_rtax_features(FILE *fp, unsigned int features)
>  		fprintf(fp, " 0x%x", of);
>  }
>  
> +static void print_expires(FILE *fp, __s32 expires, int hz)
> +{
> +	if (expires > 0)
> +		fprintf(fp, " expires %dsec", expires/hz);
> +	else
> +		fprintf(fp, " expired %dsec", -expires/hz);
> +}
Perhaps something that differs by more than a single character, to
make it stand out more?  I don't know what to suggest, though.

-Ed