netdev - Re: [PATCH net] macsec: use after free when deleting the underlying device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160811.095913.971401938578495068.davem@davemloft.net>
Date:	Thu, 11 Aug 2016 09:59:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sd@...asysnail.net
Cc:	netdev@...r.kernel.org, hannes@...essinduktion.org
Subject: Re: [PATCH net] macsec: use after free when deleting the
 underlying device

From: Sabrina Dubroca <sd@...asysnail.net>
Date: Thu, 11 Aug 2016 15:24:27 +0200

> macsec_notify() loops over the list of macsec devices configured on the
> underlying device when this device is being removed.  This list is part
> of the rx_handler data.
> 
> However, macsec_dellink unregisters the rx_handler and frees the
> rx_handler data when the last macsec device is removed from the
> underlying device.
> 
> Add macsec_common_dellink() to delete macsec devices without
> unregistering the rx_handler and freeing the associated data.
> 
> Fixes: 960d5848dbf1 ("macsec: fix memory leaks around rx_handler (un)registration")
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied, thanks.