netdev - Re: [PATCH net v1 1/1] tipc: fix variable dereference before NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160810.175713.50573275943841545.davem@davemloft.net>
Date:	Wed, 10 Aug 2016 17:57:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	parthasarathy.bhuvaragan@...csson.com
Cc:	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net v1 1/1] tipc: fix variable dereference before NULL
 check

From: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>
Date: Wed, 10 Aug 2016 14:07:34 +0200

> In commit cf6f7e1d5109 ("tipc: dump monitor attributes"),
> I dereferenced a pointer before checking if its valid.
> This is reported by static check Smatch as:
> net/tipc/monitor.c:733 tipc_nl_add_monitor_peer()
>      warn: variable dereferenced before check 'mon' (see line 731)
> 
> In this commit, we check for a valid monitor before proceeding
> with any other operation.
> 
> Fixes: cf6f7e1d5109 ("tipc: dump monitor attributes")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@...csson.com>

Applied, thank you.