netdev - Re: [PATCH/RFC net] gre: set inner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160812151521.GA25506@penelope.isobedori.kobe.vergenet.net>
Date:	Fri, 12 Aug 2016 17:15:22 +0200
From:	Simon Horman <simon.horman@...ronome.com>
To:	Alexander Duyck <alexander.duyck@...il.com>
Cc:	Netdev <netdev@...r.kernel.org>,
	Alexander Duyck <aduyck@...antis.com>
Subject: Re: [PATCH/RFC net] gre: set inner_protocol on xmit

On Fri, Aug 12, 2016 at 08:07:00AM -0700, Alexander Duyck wrote:
> On Fri, Aug 12, 2016 at 2:46 AM, Simon Horman
> <simon.horman@...ronome.com> wrote:
> > Ensure that the inner_protocol is set on transmit so that GSO segmentation,
> > which relies on that field, works correctly.
> >
> > I have observed this is not the case when OvS transmits GRE using
> > lwtunnel metadata (which it always does).
> >
> > Fixes: 38720352412a ("gre: Use inner_proto to obtain inner header protocol")
> > Cc: Alexander Duyck <aduyck@...antis.com>
> > Reviewed-by: Dinan Gunawardena <dinan.gunawardena@...ronome.com>
> > Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> > Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> 
> Looks good.  I'm surprised we had such a difference in how this was
> handled between the flow based and device based paths.
> 
> Acked-by: Alexander Duyck <alexander.h.duyck@...el.com>

Thanks, I have reposted with the above Ack and no RFC designation.