lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20160812.104919.412008599153333225.davem@davemloft.net>
Date:	Fri, 12 Aug 2016 10:49:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Sudarsana.Kalluru@...gic.com
Cc:	weiyj.lk@...il.com, Yuval.Mintz@...gic.com, Ariel.Elior@...gic.com,
	Dept-EngEverestLinuxL2@...gic.com, netdev@...r.kernel.org
Subject: Re: [PATCH -next] qed: Fix possible memory leak in
 qed_dcbnl_get_ieee_pfc()

From: Sudarsana Kalluru <Sudarsana.Kalluru@...gic.com>
Date: Fri, 12 Aug 2016 05:00:40 +0000

> Thanks for the patch.
> 
> Acked-by: Sudarsana Reddy Kalluru <sudarsana.kalluru@...gic.com>

Please do not quote patches like this, and top-post your Ack.

Please instead use canonical quoting, with some kind of delimiter
in the first column of the quoted material.

Unless you have specific comments for specific parts of the change
itself, do not quote the patch, just quoting the commit message itself
is sufficient.

And finally, put your ACK and any other part of your response, after
the quoted material rather than before.

The way you have ACK'd this patch, patchwork will not see it and
instead thinks this is a fresh new patch posting.  So your ACK will
get possibly lost, and I will definitely have more work to do weeding
out this extraneous patch entry in patchwork.

Thank you.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ